Skip to content

fix bug #274 Delete vm only command completed with output:"null"#798

Merged
GilGald merged 2 commits intodevelopfrom
feature/apiddubny_bug_274_null_in_output_for_delete_vm_command
Sep 20, 2016
Merged

fix bug #274 Delete vm only command completed with output:"null"#798
GilGald merged 2 commits intodevelopfrom
feature/apiddubny_bug_274_null_in_output_for_delete_vm_command

Conversation

@anthony-poddubny
Copy link
Copy Markdown

@anthony-poddubny anthony-poddubny commented Sep 19, 2016

Description

  • Don't serialize response command if response is None

Breaking

NO


This change is Reviewable

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 19, 2016

Coverage Status

Coverage decreased (-0.01%) to 85.873% when pulling 2a91d51 on feature/apiddubny_bug_274_null_in_output_for_delete_vm_command into 9575a50 on develop.

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 19, 2016

Coverage Status

Coverage decreased (-0.01%) to 85.813% when pulling 9e62df6 on feature/apiddubny_bug_274_null_in_output_for_delete_vm_command into 7960587 on develop.

@GilGald
Copy link
Copy Markdown
Contributor

GilGald commented Sep 20, 2016

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@GilGald GilGald merged commit 5d6efe0 into develop Sep 20, 2016
@anthony-poddubny anthony-poddubny deleted the feature/apiddubny_bug_274_null_in_output_for_delete_vm_command branch October 12, 2016 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants